xf86-input-synaptics: Changes to 'synaptics-1.3-branch'

Peter Hutterer whot at kemper.freedesktop.org
Tue Nov 30 15:24:02 PST 2010


New branch 'synaptics-1.3-branch' available with the following commits:
commit a29f55ab47e1df8f73e9bd5015c129478dd5b662
Author: Takashi Iwai <tiwai at suse.de>
Date:   Fri Oct 8 19:22:29 2010 +0200

    Fix 64bit arch issue in synaptics eventcomm.c
    
    In C, "1" is an integer, not an unsigned long. Thus (1 << 33) doesn't give
    you the 33th bit shift, but it's undefined.
    
    Signed-off-by: Takashi Iwai <tiwai at suse.de>
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    (cherry picked from commit 4d22aa06fd2b53e11233ebd3a25045cd96bf67ab)

commit 1251ca15b644854a68aaa7d2046ae50fee3334a7
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Wed Dec 1 09:10:04 2010 +1000

    don't post motion events if the finger state is FS_UNTOUCHED
    
    Works around some buggy touchpads that report their position as things
    like 0,0; 0,ymax; etc. at the same time as they turn off the finger
    tool and/or touch indication.  This is particularly a problem when
    using the touchpad in absolute mode.
    
    Signed-off-by: Joe Shaw <joe at joeshaw.org>
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    (cherry picked from commit e2260fef76b08f782ab5640ae490d9b2da33c94b)
    
    Conflicts:
    
    	src/synaptics.c
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

commit 201af554b1bdd52e42989364a780aa2e3c38fa61
Author: Peter Hutterer <peter.hutterer at who-t.net>
Date:   Wed Dec 1 09:03:18 2010 +1000

    config: don't autoprobe when device was set
    
    If device was already set, we were asked to handle that specific device
    and we should not go probing around. If we do, we might end up handling
    a device different from what the X server thinks we are handling, with
    dire consequences in case of hot plugging and unplugging.
    
    Without this patch, a situation such as the following can happen.
    
    A user has both a built-in laptop touchpad and a tablet such as the
    Wacom Bamboo Pen & Touch, that is also exposed as a touchpad.
    
    The tablet is plugged in before the server starts, and during setup the
    server calls the synaptic driver for the /dev/input/mouseX device
    corresponding to the touch device of the tablet; we end up in the
    autoprobe path even though `device' was set, and the driver scans
    /dev/input, where the first useful device it finds is the event device
    for the built-in touchpad.
    
    The driver starts managing the built-in touchpad, preventing future
    instances from managing it too, while the server thinks the driver is
    managing the tablet.
    
    When the user disconnects the tablet, the corresponding instance of the
    synpatics driver (which is actually managing the touchpad instead) is
    unloaded: the built-in touchpad stops working in X.
    
    Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta at gmail.com>
    Reviewed-by: Chase Douglas <chase.douglas at canonical.com>
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
    (cherry picked from commit f5687a6741a19ef3081e7fd83ac55f6df8bcd5c2)
    
    Conflicts:
    
    	src/synaptics.c
    
    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>



More information about the xorg-commit mailing list