xf86-video-intel: src/intel_driver.c

Eric Anholt anholt at kemper.freedesktop.org
Tue Nov 2 10:59:19 PDT 2010


 src/intel_driver.c |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 8ff37667bf864b771d16a58fc5041cb48408b6a8
Author: Eric Anholt <eric at anholt.net>
Date:   Tue Nov 2 10:36:03 2010 -0700

    Remove the intermittent GEM_THROTTLE call.
    
    This is a holdover from early GEM work when we weren't syncing on the
    DRI client side.  It would keep clients from getting too far ahead and
    killing their interactivity, by bringing everyone to a halt when
    anyone was too far ahead.
    
    Now, GL clients throttle themselves to avoid the problem, and it turns
    out that in the case that they don't (long rendering to buffers with
    no swap), this actually reduces X Server interactivity: instead of
    lagging of X rendering behind input, you get no response for seconds
    at a time, then a burst of rendering, then nothing again.
    
    Reported by ajax.  Tested with moving a window while running
    cairo-perf-trace on the GL backend (improvement) and X backend (no
    significant change in responsiveness).

diff --git a/src/intel_driver.c b/src/intel_driver.c
index 01c8c1b..fd51899 100644
--- a/src/intel_driver.c
+++ b/src/intel_driver.c
@@ -688,9 +688,6 @@ I830BlockHandler(int i, pointer blockData, pointer pTimeout, pointer pReadmask)
 	intel->BlockHandler = screen->BlockHandler;
 	screen->BlockHandler = I830BlockHandler;
 
-	if (scrn->vtSema == TRUE)
-		drmCommandNone(intel->drmSubFD, DRM_I915_GEM_THROTTLE);
-
 	intel_uxa_block_handler(intel);
 	intel_video_block_handler(intel);
 }


More information about the xorg-commit mailing list