xdm: Changes to 'master'

[Alan Coopersmith]

 dm.c            |   13 +++++++++++++
 greeter/greet.c |    3 ---
 2 files changed, 13 insertions(+), 3 deletions(-)

New commits:
commit ecf015a4e78b96af913c1620d542c8e356f2a3d0
Author: Dmitry V. Levin <ldv at altlinux.org>
Date:   Mon Jan 11 23:09:47 2010 +0000

    Call openlog(3) early
    
    Before this change, openlog(3) used to be called by greeter which could
    be built as a dynamically loadable plugin.  In the latter case, the
    ident string passed to openlog(3) resides in a dynamically mapped
    memory region that is unmapped later when the plugin is unloaded.
    This can cause fatal problems in some environments.  For example, in
    any GNU/Linux system with PAM support enabled an implicit syslog(3)
    call made by a PAM module after plugin unload causes attempt to access
    already unmapped memory, followed by instant crash.
    
    It is a common practice to call openlog(3) before the first syslog(3)
    call, including implicit calls that could be made e.g. by PAM.
    Also, openlog(3) LOG_ODELAY flag is redundant.
    
    Fixes ALT Linux Bug #22362 <https://bugzilla.altlinux.org/show_bug.cgi?id=22362>
    Fixes FreeDesktop Bug #24589 <https://bugs.freedesktop.org/show_bug.cgi?id=24589>
    
    Reported-by: Martin Mokrejš <mmokrejs at ribosome.natur.cuni.cz>
    Reported-by: Denis Kirienko <dk at altlinux.org>
    Patch-by: Oleg Zenin <tt at compas.ihep.su>
    Signed-off-by: Dmitry V. Levin <ldv at altlinux.org>
    Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>