xserver: Branch 'server-1.8-branch'

Jeremy Huddleston jeremyhu at kemper.freedesktop.org
Fri Dec 3 22:09:31 PST 2010


 render/render.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 96cf8a77ac067dc9b1958a7f577d22904610c86f
Author: Andrea Canciani <ranma42 at gmail.com>
Date:   Tue Nov 2 20:10:32 2010 +0100

    render: Fix byteswapping of gradient stops
    
    The function swapStops repeatedly swaps the color components as
    CARD16, but incorrectly steps over them as if they were CARD32.
    
    This causes half of the stops not to be swapped at all and some
    unrelated data be swapped instead.
    
    Signed-off-by: Andrea Canciani <ranma42 at gmail.com>
    Reviewed-by: Soren Sandmann <sandmann at daimi.au.dk>
    Reviewed-by: Julien Cristau <jcristau at debian.org>
    Signed-off-by: Keith Packard <keithp at keithp.com>
    (cherry picked from commit dab064fa5e0b1f5c67222562ad5367005832cba1)

diff --git a/render/render.c b/render/render.c
index 2779818..fbd0727 100644
--- a/render/render.c
+++ b/render/render.c
@@ -2572,8 +2572,8 @@ static void swapStops(void *stuff, int num)
     }
     colors = (CARD16 *)(stops);
     for (i = 0; i < 4*num; ++i) {
-        swaps(stops, n);
-        ++stops;
+        swaps(colors, n);
+        ++colors;
     }
 }
 


More information about the xorg-commit mailing list