xf86-video-intel: src/i830_uxa.c

Chris Wilson ickle at kemper.freedesktop.org
Tue Dec 1 05:23:45 PST 2009


 src/i830_uxa.c |   12 ------------
 1 file changed, 12 deletions(-)

New commits:
commit 637f003b047e426901cab6b1fe3a0924bcb9a38a
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Dec 1 13:20:20 2009 +0000

    uxa: Don't treat prepare_access as a flush synchronisation point.
    
    The kernel will only emit a flush iff the buffer is currently owned by
    the GPU. Instead of presuming that the kernel must emit a flush, it is
    safer to assume that it does not and so cannot mapping the buffer on to
    the CPU as a synchronisation point. The most obvious counter-example is
    when we map the same buffer twice without using it in a batch.
    
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

diff --git a/src/i830_uxa.c b/src/i830_uxa.c
index 801c2c7..4d7ecb7 100644
--- a/src/i830_uxa.c
+++ b/src/i830_uxa.c
@@ -592,18 +592,6 @@ static Bool i830_uxa_prepare_access(PixmapPtr pixmap, uxa_access_t access)
 	}
 	pixmap->devPrivate.ptr = bo->virtual;
 
-	/* This acts as a synchronisation point. */
-	while (!list_is_empty(&intel->flush_pixmaps)) {
-		struct intel_pixmap *entry;
-
-		entry = list_first_entry(&intel->flush_pixmaps,
-					 struct intel_pixmap,
-					 flush);
-
-		entry->flush_read_domains = entry->flush_write_domain = 0;
-		list_del(&entry->flush);
-	}
-
 	return TRUE;
 }
 


More information about the xorg-commit mailing list