xserver: Branch 'master'

Alan Coopersmith alanc at kemper.freedesktop.org
Fri Apr 24 10:15:54 PDT 2009


 hw/xfree86/os-support/shared/sigio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a1c98f7fa9aa0cd5075ef2054c5d2be4d1e740f0
Author: Joel Bosveld <Joel.Bosveld at gmail.com>
Date:   Fri Apr 24 10:12:26 2009 -0700

    Correct fcntl(F_SETOWN) error check in non-Solaris sigio code
    
    commit 64b7f96dca accidentally inverted the comparison, could
    result in crashes on some systems later on.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>

diff --git a/hw/xfree86/os-support/shared/sigio.c b/hw/xfree86/os-support/shared/sigio.c
index 2565782..5ba0b7e 100644
--- a/hw/xfree86/os-support/shared/sigio.c
+++ b/hw/xfree86/os-support/shared/sigio.c
@@ -157,7 +157,7 @@ xf86InstallSIGIOHandler(int fd, void (*f)(int, void *), void *closure)
 		xf86Msg(X_WARNING, "fcntl(%d, O_ASYNC): %s\n",
 			fd, strerror(errno));
 	    } else {
-		if (fcntl(fd, F_SETOWN, getpid()) != -1) {
+		if (fcntl(fd, F_SETOWN, getpid()) == -1) {
 		    xf86Msg(X_WARNING, "fcntl(%d, F_SETOWN): %s\n",
 			    fd, strerror(errno));
 		} else {


More information about the xorg-commit mailing list