xserver: Branch 'master'

Eamon Walsh ewalsh at kemper.freedesktop.org
Wed Apr 8 23:49:42 PDT 2009


 Xext/xselinux.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 682d7b55699cacbb2dbcd84a5e816bf6e2d2f02a
Author: Eamon Walsh <ewalsh at tycho.nsa.gov>
Date:   Thu Apr 9 02:48:04 2009 -0400

    xselinux: Don't BadAlloc in List* requests if there are no items to list.

diff --git a/Xext/xselinux.c b/Xext/xselinux.c
index 399e28a..2c72621 100644
--- a/Xext/xselinux.c
+++ b/Xext/xselinux.c
@@ -1567,7 +1567,7 @@ SELinuxSendItemsToClient(ClientPtr client, SELinuxListItemRec *items,
     CARD32 *buf;
 
     buf = xcalloc(size, sizeof(CARD32));
-    if (!buf) {
+    if (size && !buf) {
 	rc = BadAlloc;
 	goto out;
     }
@@ -1639,7 +1639,7 @@ ProcSELinuxListProperties(ClientPtr client)
     for (pProp = wUserProps(pWin); pProp; pProp = pProp->next)
 	count++;
     items = xcalloc(count, sizeof(SELinuxListItemRec));
-    if (!items)
+    if (count && !items)
 	return BadAlloc;
 
     /* Fill in the items and calculate size */
@@ -1673,7 +1673,7 @@ ProcSELinuxListSelections(ClientPtr client)
     for (pSel = CurrentSelections; pSel; pSel = pSel->next)
 	count++;
     items = xcalloc(count, sizeof(SELinuxListItemRec));
-    if (!items)
+    if (count && !items)
 	return BadAlloc;
 
     /* Fill in the items and calculate size */


More information about the xorg-commit mailing list