xf86-input-synaptics:synaptics-1.0-branch: 2 commit(s)

[Peter Hutterer]

Reporting from xf86-input-synaptics: xf86-input-synaptics driver

Please visit:
    http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics
Or get your own copy by using:
    git-clone git://anongit.freedesktop.org/xorg/driver/xf86-input-synaptics

2 commits against synaptics-1.0-branch at 34e200e8...:
 src/synaptics.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


commit bfb264eaccdcaab36d11f937c3592cf26241a929
Author: Batchty <batchman at free.fr>
Date:   Mon Nov 24 11:31:48 2008 +1000

    Stop two-finger scrolling if no finger is present.
    
    Signed-off-by: Peter Hutterer <peter.hutterer at redhat.com>
    Signed-off-by: Simon Thum <eGore at gmx.de>
    Signed-off-by: Henrik Rydberg <rydberg at euromail.se>
    (cherry picked from commit 13c93be34dfcd0e57b14f86688fd2ad4efda028c)

diffstat:
    src/synaptics.c |    2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=bfb264ea


commit 9c63952313ecd93770d2eee2580aca69bbe94787
Author: Batchty <batchman at free.fr>
Date:   Sun Nov 23 20:46:14 2008 +0100

    Ignore moves during tap processing if no finger is down.
    
    The Dell Inspiron 1520 with a Synaptics touchpad loves to send event like
    these after every finger release :
    
        time     x    y   z f  w  l r u d m     multi  gl gm gr gdx gdy
       1.563  3224 1625  57 1  5  0 0 0 0 0  00000000   0  0  0   0   0
       1.574  3251 1632  30 1  5  0 0 0 0 0  00000000   0  0  0   0   0
       1.584  3292 1673  10 1  5  0 0 0 0 0  00000000   0  0  0   0   0
       1.594     1 5855   3 2  5  0 0 0 0 0  00000000   0  0  0   0   0
       1.634     1 5855   1 2  5  0 0 0 0 0  00000000   0  0  0   0   0
       1.746     1 5855   0 0  0  0 0 0 0 0  00000000   0  0  0   0   0
       1.897     1 5855   1 2  5  0 0 0 0 0  00000000   0  0  0   0   0
    
    Most of the time these events are ignored by the driver, but sometimes it
    confuses two-finger scrolling and tap detection.
    
    For example, in this log, the first tap is recognized, the second isn't :
    
        time     x    y   z f  w  l r u d m     multi  gl gm gr gdx gdy
      11.597     1 5855   1 2  5  0 0 0 0 0  00000000   0  0  0   0   0
      11.678     1 5855   0 0  0  0 0 0 0 0  00000000   0  0  0   0   0
      11.688     1 5855   1 2  5  0 0 0 0 0  00000000   0  0  0   0   0
      11.709  3862 2406   8 1  5  0 0 0 0 0  00000000   0  0  0   0   0
      11.719  3851 2464  67 1  5  0 0 0 0 0  00000000   0  0  0   0   0
      11.729  3849 2407  35 1  4  0 0 0 0 0  00000000   0  0  0   0   0
      11.739  3858 2578   5 1  9  0 0 0 0 0  00000000   0  0  0   0   0
      11.749  3858 2578   0 0  0  0 0 0 0 0  00000000   0  0  0   0   0
      11.850     1 5855   1 2  5  0 0 0 0 0  00000000   0  0  0   0   0
      11.860     1 5855   0 0  0  0 0 0 0 0  00000000   0  0  0   0   0
      12.073     1 5855   1 2  5  0 0 0 0 0  00000000   0  0  0   0   0
      12.083     1 5855   0 0  0  0 0 0 0 0  00000000   0  0  0   0   0
      12.347     1 5855   4 2  5  0 0 0 0 0  00000000   0  0  0   0   0
      12.357  3844 2381  56 1  4  0 0 0 0 0  00000000   0  0  0   0   0
      12.377  3848 2361  32 1  4  0 0 0 0 0  00000000   0  0  0   0   0
      12.388     1 5855   3 2  5  0 0 0 0 0  00000000   0  0  0   0   0
      12.398     1 5855   1 2  5  0 0 0 0 0  00000000   0  0  0   0   0
      12.408     1 5855   0 0  0  0 0 0 0 0  00000000   0  0  0   0   0
      12.428     1 5855   1 2  5  0 0 0 0 0  00000000   0  0  0   0   0
    
    The problem with the second tap is that the driver check if the movement from
    (3848,2361) to (1,5855) is over TapMaxMove before it checks for a finger release.
    So the driver considers it as a (short) finger move.
    Add the condition ''the finger is still present'' to the 'move' condition, so
    we ignore these moves..
    
    Signed-off-by: Peter Hutterer <peter.hutterer at redhat.com>
    Signed-off-by: Simon Thum <eGore at gmx.de>
    Signed-off-by: Henrik Rydberg <rydberg at euromail.se>
    (cherry picked from commit 6cbdb0a10574d57a563337adb54afdf89996bc36)

diffstat:
    src/synaptics.c |    2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

gitweb url:
http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics;a=commit;h=bfb264ea