xserver: Branch 'xorg-server-1.4-apple' - 2 commits

Jeremy Huddleston jeremyhu at kemper.freedesktop.org
Thu Nov 13 11:32:56 PST 2008


 hw/xquartz/mach-startup/stub.c |   14 ++++++++------
 hw/xquartz/quartzAudio.c       |    2 +-
 2 files changed, 9 insertions(+), 7 deletions(-)

New commits:
commit aa0e9ab1c7a226cdcb3c5e62be159355a290faf8
Author: Jeremy Huddleston <jeremyhu at freedesktop.org>
Date:   Thu Nov 13 11:32:40 2008 -0800

    XQuartz: Fixed XBell() when not using system alert.

diff --git a/hw/xquartz/quartzAudio.c b/hw/xquartz/quartzAudio.c
index 603ca4a..ac9f820 100644
--- a/hw/xquartz/quartzAudio.c
+++ b/hw/xquartz/quartzAudio.c
@@ -338,7 +338,7 @@ void QuartzAudioInit(void)
 
     // Prepare for playback
     AudioDeviceIOProcID sInputIOProcID = NULL;
-    status = AudioDeviceCreateIOProcID( outputDevice, QuartzAudioIOProc, NULL, &sInputIOProcID );
+    status = AudioDeviceCreateIOProcID( outputDevice, QuartzAudioIOProc, &data, &sInputIOProcID );
     if (status) {
         ErrorF("QuartzAudioInit: AddIOProc returned %ld\n", (long)status);
         return;
commit acefa7e3c8706ffedc052effd50b36ce10e72c22
Author: Jeremy Huddleston <jeremyhu at freedesktop.org>
Date:   Thu Nov 13 11:10:15 2008 -0800

    XQuartz: Added more debugging to handoff spew

diff --git a/hw/xquartz/mach-startup/stub.c b/hw/xquartz/mach-startup/stub.c
index 8bbd4d9..a011c4e 100644
--- a/hw/xquartz/mach-startup/stub.c
+++ b/hw/xquartz/mach-startup/stub.c
@@ -178,17 +178,15 @@ static void send_fd_handoff(int connected_fd, int launchd_fd) {
     
     *((int*)CMSG_DATA(cmsg)) = launchd_fd;
     
-#ifdef DEBUG
-    fprintf(stderr, "Xquartz: Handoff connection established.  Sending message.\n");
-#endif
     if(sendmsg(connected_fd, &msg, 0) < 0) {
-        fprintf(stderr, "Xquartz: Error sending $DISPLAY file descriptor: %s\n", strerror(errno));
+        fprintf(stderr, "Xquartz: Error sending $DISPLAY file descriptor over fd %d: %d -- %s\n", connected_fd, errno, strerror(errno));
         return;
     }
 
 #ifdef DEBUG
-    fprintf(stderr, "Xquartz: Message sent.  Closing.\n");
+    fprintf(stderr, "Xquartz: Message sent.  Closing handoff fd.\n");
 #endif
+
     close(connected_fd);
 }
 
@@ -279,13 +277,17 @@ int main(int argc, char **argv, char **envp) {
                 fprintf(stderr, "Xquartz: Failed to request a socket from the server to send the $DISPLAY fd over (try %d of %d)\n", (int)try+1, (int)try_max);
                 continue;
             }
-            
+
             handoff_fd = connect_to_socket(handoff_socket_filename);
             if(handoff_fd == -1) {
                 fprintf(stderr, "Xquartz: Failed to connect to socket (try %d of %d)\n", (int)try+1, (int)try_max);
                 continue;
             }
 
+#ifdef DEBUG
+            fprintf(stderr, "Xquartz: Handoff connection established (try %d of %d) on fd %d, \"%s\".  Sending message.\n", (int)try+1, (int)try_max, handoff_fd, handoff_socket_filename);
+#endif
+
             send_fd_handoff(handoff_fd, launchd_fd);            
             close(handoff_fd);
             break;


More information about the xorg-commit mailing list