libXft: Changes to 'master'
Keith Packard
keithp at kemper.freedesktop.org
Wed Sep 12 04:01:18 PDT 2007
src/xftfreetype.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
New commits:
commit 8ae5ea8c75a7850fa0aca0acc3962b6263f55094
Author: Karl Tomlinson <bugs.freedesktop at karlt.net>
Date: Wed Sep 12 12:00:43 2007 +0100
XftFontOpenInfo: Use of uninitialised value of size 8 (bug 11200)
This is due to XftFontInfoFill using the binary representation of the
XftFontInfo to generate fi->hash.
With 64-bit pointers there is padding between .hash and .file in struct
_XftFontInfo. This padding is not initialized, and the hash uses these
bytes.
This will interfere with finding "a matching previously opened font" in
XftFontOpenInfo, and XftFontInfoEqual, which uses memcmp, will have similar
problems.
This fix makes no assumptions about the sizes and alignment of members of
struct _XftFontInfo by using memset. (It also makes no assumptions about
what FcPatternGet* does to its output parameter when it returns
FcResultNoMatch.)
More information about the xorg-commit
mailing list