xprop: Changes to 'master'

James Cloos cloos at kemper.freedesktop.org
Thu Dec 6 02:32:48 PST 2007


 Makefile.am  |    2 
 clientwin.c  |  214 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 clientwin.h  |   29 +++++++
 configure.ac |    2 
 dsimple.c    |    8 +-
 dsimple.h    |    2 
 xprop.c      |   16 ----
 7 files changed, 256 insertions(+), 17 deletions(-)

New commits:
commit e09956f244099ddd36b1a2cd5d7800d5fc7120c1
Author: Kim Woelders <kim at woelders.dk>
Date:   Thu Dec 6 05:30:43 2007 -0500

    Select correct client window in WM’s using virtual roots
    From bug 2185¹
    
    When manually selecting a window, xprop finds the top-level window containing
    the pointer and uses XmuClientWindow to attempt to find a client window having
    WM_STATE set.
    
    In a WM using virtual roots (e.g. enlightenment, desks other than first) this
    fails beacuse the top-level window is a virtual root, and XmuClientWindow seems
    to find the first client having WM_STATE set, which only by coincidence will be
    the one the user intended to select (i.e. containing the pointer).
    
    The solution is to descend the window hierarchy at the pointer location to find
    a window with WM_STATE set.
    
    1] https://bugs.freedesktop.org/show_bug.cgi?id=2185
    
    Signed-off-by: James Cloos <cloos at jhcloos.com>



More information about the xorg-commit mailing list