CVS Update: xc (branch: trunk)

Egbert Eich xorg-commit at cvs.freedesktop.org
Wed May 18 13:31:53 EEST 2005


CVSROOT:	/cvs/xorg
Module name:	xc
Changes by:	eich at gabe.freedesktop.org	05/05/18 03:31:53

Log message:
  2005-05-18  Egbert Eich  <eich-at-freedesktop-dot-org>
  
          * programs/Xserver/hw/xfree86/common/xf86Config.c: (configMonitor):
          Avoid segfaults if the number of user supplied monitor ranges
          exceed the number of preallocated slots. We should really make this
          dynamic - but I don't think this ever caused a problem so it's
          more or less academic.
          * programs/Xserver/hw/xfree86/common/xf86Mode.c: (ModeHSync),
          (ModeVRefresh), (xf86SetModeCrtc), (xf86CheckModeForMonitor),
          (xf86InitialCheckModeForDriver), (xf86ValidateModes),
          (xf86PrintModes):
          A. Avoid that *SyncStart starts before *BlankStart. If *BlankStart >
            *SyncStart it is made = *SyncStart and its width is made maximal
            but such that the blank does not exceed *Total. Since the Sync
            width has the same restrictions as the Blank width monitors
            should still be able to clamp after the sync pulse.
          B. Over time mode validation has become inconsistent when people
            started to add additional features to the mode validation. One
            such feature is that the mode->Crtc* values have been (ab)used
            to allow the driver ValidMode() function to pass driver
            normalized timing values back to the validation function.
            The introduction of these features made the code less readable
            and created numerous possibly unintended side effects in the
            validation semantics.
            I've attempted to consolidate these changes making the code
            more consistent and eliminating a number of side effects.
            This should not cause problems for the majority of drivers,
            still it should receive testing - especially with ATi Mach64
            and Radeon code.
             (Bugzilla #3325).

Modified files:
      ./:
        ChangeLog 
      xc/programs/Xserver/hw/xfree86/common/:
        xf86Config.c xf86Mode.c 
  
  Revision      Changes    Path
  1.934         +31 -0     xc/ChangeLog
  1.8           +8 -4      xc/programs/Xserver/hw/xfree86/common/xf86Config.c
  1.4           +100 -96   xc/programs/Xserver/hw/xfree86/common/xf86Mode.c




More information about the xorg-commit mailing list