[Xf86-video-armsoc] [PATCH 1/1] Clarify assumptions on window front buffer pixmaps

armsoc-bugs at arm.com armsoc-bugs at arm.com
Tue May 27 07:16:48 PDT 2014

From: Raymond Smith <raymond.smith at arm.com>

We assume that a window's front buffer pixmap won't be reallocated
from beneath us. This commit updates a comment to reflect this

Change-Id: Ic1ddc508dee8b1696643dd418ddb466fbce9d8fb
 src/armsoc_dri2.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/armsoc_dri2.c b/src/armsoc_dri2.c
index 793ea10..7d05575 100644
--- a/src/armsoc_dri2.c
+++ b/src/armsoc_dri2.c
@@ -48,9 +48,8 @@ struct ARMSOCDRI2BufferRec {
 	 * Pixmap(s) that are backing the buffer
-	 * NOTE: don't track the pixmap ptr for the front buffer if it is
-	 * a window.. this could get reallocated from beneath us, so we should
-	 * always use draw2pix to be sure to have the correct one
+	 * We assume that a window's front buffer pixmap is never reallocated,
+	 * and therefore that it is safe to use the pointer to it stored here.
 	PixmapPtr *pPixmaps;

More information about the Xf86-video-armsoc mailing list