[Mesa-dev] [PATCH 36/53] intel/fs: Simplify fs_visitor::emit_samplepos_setup

[Jason Ekstrand]

On Thu, May 31, 2018 at 10:24 AM, Matt Turner <mattst88 at gmail.com> wrote:

> On Thu, May 24, 2018 at 2:56 PM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > From: Francisco Jerez <currojerez at riseup.net>
> >
> > Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
>
> Some small explanation that this is possible since we're able to rely
> on lower_simd_width() to do the hard work for us might be nice.
>

    The original code manually handled splitting the MOVs to 8-wide to
    handle various regioning restrictions.  Now that we have a SIMD width
    splitting pass that handles these things, we can just emit everything at
    the full width and let the SIMD splitting pass handle it.  We also now
    have a useful "subscript" helper which is designed exactly for the case
    where you want to take a W type and read it as a vector of Bs so we may
    as well use that too.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180531/a36e27df/attachment.html>