[Mesa-dev] [PATCH 1/3] radv: Make the sem_info allocate/free functions static.

[Samuel Pitoiset]

On 05/31/2018 11:03 AM, Samuel Pitoiset wrote:
> Series is:

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

> 
> 
> 
> On 05/31/2018 01:51 AM, Bas Nieuwenhuizen wrote:
>> They are only used in 1 file.
>> ---
>>   src/amd/vulkan/radv_device.c  | 16 +++++++++-------
>>   src/amd/vulkan/radv_private.h |  8 --------
>>   2 files changed, 9 insertions(+), 15 deletions(-)
>>
>> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
>> index 93b6e611067..9709e73a4fe 100644
>> --- a/src/amd/vulkan/radv_device.c
>> +++ b/src/amd/vulkan/radv_device.c
>> @@ -2349,7 +2349,8 @@ static VkResult radv_alloc_sem_counts(struct 
>> radv_winsys_sem_counts *counts,
>>       return VK_SUCCESS;
>>   }
>> -void radv_free_sem_info(struct radv_winsys_sem_info *sem_info)
>> +static void
>> +radv_free_sem_info(struct radv_winsys_sem_info *sem_info)
>>   {
>>       free(sem_info->wait.syncobj);
>>       free(sem_info->wait.sem);
>> @@ -2372,12 +2373,13 @@ static void radv_free_temp_syncobjs(struct 
>> radv_device *device,
>>       }
>>   }
>> -VkResult radv_alloc_sem_info(struct radv_winsys_sem_info *sem_info,
>> -                 int num_wait_sems,
>> -                 const VkSemaphore *wait_sems,
>> -                 int num_signal_sems,
>> -                 const VkSemaphore *signal_sems,
>> -                 VkFence fence)
>> +static VkResult
>> +radv_alloc_sem_info(struct radv_winsys_sem_info *sem_info,
>> +            int num_wait_sems,
>> +            const VkSemaphore *wait_sems,
>> +            int num_signal_sems,
>> +            const VkSemaphore *signal_sems,
>> +            VkFence fence)
>>   {
>>       VkResult ret;
>>       memset(sem_info, 0, sizeof(*sem_info));
>> diff --git a/src/amd/vulkan/radv_private.h 
>> b/src/amd/vulkan/radv_private.h
>> index 708cacf7708..e241283346a 100644
>> --- a/src/amd/vulkan/radv_private.h
>> +++ b/src/amd/vulkan/radv_private.h
>> @@ -1744,14 +1744,6 @@ struct radv_semaphore {
>>       uint32_t temp_syncobj;
>>   };
>> -VkResult radv_alloc_sem_info(struct radv_winsys_sem_info *sem_info,
>> -                 int num_wait_sems,
>> -                 const VkSemaphore *wait_sems,
>> -                 int num_signal_sems,
>> -                 const VkSemaphore *signal_sems,
>> -                 VkFence fence);
>> -void radv_free_sem_info(struct radv_winsys_sem_info *sem_info);
>> -
>>   void radv_set_descriptor_set(struct radv_cmd_buffer *cmd_buffer,
>>                    VkPipelineBindPoint bind_point,
>>                    struct radv_descriptor_set *set,
>>