[Mesa-dev] [PATCH] i965: Only emit VF cache invalidations when the high bits changes

[Kenneth Graunke]

On Tuesday, May 29, 2018 9:28:07 AM PDT Chris Wilson wrote:
> Commit 92f01fc5f914 ("i965: Emit VF cache invalidates for 48-bit
> addressing bugs with softpin.") tried to only emit the VF invalidate if
> the high bits changed, but it accidentally always set need_invalidate to
> true; causing it to emit unconditionally emit the pipe control before
> every primitive.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106708
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> Cc: Scott D Phillips <scott.d.phillips at intel.com>
> Cc: Eero Tamminen <eero.t.tamminen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index b485e2cf811..88fde9d12fd 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -504,7 +504,7 @@ static void
>  vf_invalidate_for_vb_48bit_transitions(struct brw_context *brw)
>  {
>  #if GEN_GEN >= 8
> -   bool need_invalidate = true;
> +   bool need_invalidate = false;
>     unsigned i;
>  
>     for (i = 0; i < brw->vb.nr_buffers; i++) {
> 

*facepalm*...thanks Chris!

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Pushed:

To ssh://git.freedesktop.org/git/mesa/mesa
   e4fe2fd3bb2..3ac5fbadfd8  master -> master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180529/cd008ed2/attachment-0001.sig>