[Mesa-dev] [PATCH v2 4/4] i965: Require softpin support for Cannonlake and later.

[Jordan Justen]

3-4 Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On 2018-05-27 21:35:43, Kenneth Graunke wrote:
> This isn't strictly necessary, but anyone running Cannonlake will
> already have Kernel 4.5 or later, so there's no reason to support
> the relocation model on Gen10+.
> 
> This will let us avoid dealing with them for new features.
> 
> Reviewed-by: Scott D Phillips <scott.d.phillips at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_bufmgr.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c
> index 80bfc7c75db..2fb0a4453ff 100644
> --- a/src/mesa/drivers/dri/i965/brw_bufmgr.c
> +++ b/src/mesa/drivers/dri/i965/brw_bufmgr.c
> @@ -1738,6 +1738,16 @@ brw_bufmgr_init(struct gen_device_info *devinfo, int fd)
>                              4096, _4GB);
>           util_vma_heap_init(&bufmgr->vma_allocator[BRW_MEMZONE_OTHER],
>                              1 * _4GB, gtt_size - 1 * _4GB);
> +      } else if (devinfo->gen >= 10) {
> +         /* Softpin landed in 4.5, but GVT used an aliasing PPGTT until
> +          * kernel commit 6b3816d69628becb7ff35978aa0751798b4a940a in
> +          * 4.14.  Gen10+ GVT hasn't landed yet, so it's not actually a
> +          * problem - but extending this requirement back to earlier gens
> +          * might actually mean requiring 4.14.
> +          */
> +         fprintf(stderr, "i965 requires softpin (Kernel 4.5) on Gen10+.");
> +         free(bufmgr);
> +         return NULL;
>        }
>     }
>  
> -- 
> 2.17.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev