[Mesa-dev] [PATCH] radeonsi: Track pipe_vertex_buffers for relocs.

[Marek Olšák]

On Sun, May 20, 2018 at 2:21 PM, Mathias Fröhlich <Mathias.Froehlich at gmx.net
> wrote:

> Hi Marek,
>
> On Sunday, 20 May 2018 20:08:08 CEST Marek Olšák wrote:
> > The old code saves which vertex element is the first to use a VBO slot.
> > When VBOs are added to the buffer list, each VBO is added only for such
> > vertex elements, and not added for others. So the old and new code do
> > exactly the same thing but differently.
>
> But its doing that with less calls to radeon_add_to_buffer_list/amdg
> pu_cs_add_buffer.
> It avoids duplicate calls for pipe_vertex_elements refering to the same
> pipe_vertex_buffer.
>

And the old code does exactly the same thing - it avoids duplicate calls
for the same pipe_vertex_buffer, because vertex elements reusing vertex
buffer slots don't have their bit set in first_vb_use_mask, so
add_to_buffer_list is never called for those vertex elements.

Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180521/6618205c/attachment.html>