[Mesa-dev] [PATCH] bin: force git show to use default pretty setting

[Emil Velikov]

On 26 April 2018 at 19:06, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Emil Velikov (2018-04-26 11:04:01)
>> On 26 April 2018 at 18:45, Dylan Baker <dylan at pnwbakers.com> wrote:
>> > I have pretty default to short, which breaks this script.
>> >
>> Out of curiosity: why would you do this to yourself ;-)
>
> Because I use tig, so all I have to do is press enter to see the entire commit,
> log and patch :)
>
tig allows you to override the show/log/etc options ;-)

Regardless, having --pretty=medium is the right thing to do.

> Dylan
>
>>
>> > cc: Emil Velikov <emil.velikov at collabora.com>
>> > cc: Andres Gomez <agomez at igalia.com>
>> > cc: Juan A. Suarez <jasuarez at igalia.com>
>> > Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
>> > ---
>> >  bin/get-fixes-pick-list.sh | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh
>> > index fb7ef223820..983af0983dd 100755
>> > --- a/bin/get-fixes-pick-list.sh
>> > +++ b/bin/get-fixes-pick-list.sh
>> > @@ -38,7 +38,7 @@ do
>> >
>> >         # Place every "fixes:" tag on its own line and join with the next word
>> >         # on its line or a later one.
>> > -       fixes=`git show -s $sha | tr -d "\n" | sed -e 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
>> > +       fixes=`git show --pretty=medium -s $sha | tr -d "\n" | sed -e 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
>> >
>> An on a serious note - there are plenty of places that will need this
>> kind of fix.
>> Pretty much any git show/log instances that do not specify --pretty.
>>
Since you're tweaking this script, just fixup the git log --reverse
... instance further up as well.
With that the patch is:
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Addressing the other scripts can happen at a later stage.

-Emil