[Mesa-dev] [PATCH] meson: fix race condition revealed by using 0.44

[Emil Velikov]

On 26 April 2018 at 18:57, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Emil Velikov (2018-04-26 10:35:50)
>> On 26 April 2018 at 18:24, Dylan Baker <dylan at pnwbakers.com> wrote:
>> > It turns out that the blocking target we had was hiding some race
>> > conditions in the anv driver with anv_extensions.h generation, we should
>> > fix those.
>> >
>> anv_entrypoints[0] is the first output of the anv_entrypoints custom_target.
>> Aka it's effectively the same as anv_extensions_h, isn't it?
>
> Actually, there is anv_entrypoints.[ch], and anv_extensions.[ch], and it's the
> latter that we're missing as an explicit dependency (I got confused about that
> too). The thing that happened here is that the blocking target created a proper
> dependency chain, but when we removed it that was broken, and we got a race.
>
Thanks for the explanation - not sure how I read anv_entrypoints as
anv_extensions :-\

Since it seems commit to confuse the two, it would be nice to add your
description (or anything like it) to the commit message.
With that the patch is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil