[Mesa-dev] [PATCH] bin: force git show to use default pretty setting

Andres Gomez agomez at igalia.com
Fri Apr 27 07:47:51 UTC 2018


As said by Emil, this may be the case in some others scripts.

In any case, this is:

Reviewed-by: Andres Gomez <agomez at igalia.com>

On Thu, 2018-04-26 at 10:45 -0700, Dylan Baker wrote:
> I have pretty default to short, which breaks this script.
> 
> cc: Emil Velikov <emil.velikov at collabora.com>
> cc: Andres Gomez <agomez at igalia.com>
> cc: Juan A. Suarez <jasuarez at igalia.com>
> Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
> ---
>  bin/get-fixes-pick-list.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick-list.sh
> index fb7ef223820..983af0983dd 100755
> --- a/bin/get-fixes-pick-list.sh
> +++ b/bin/get-fixes-pick-list.sh
> @@ -38,7 +38,7 @@ do
>  
>  	# Place every "fixes:" tag on its own line and join with the next word
>  	# on its line or a later one.
> -	fixes=`git show -s $sha | tr -d "\n" | sed -e 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
> +	fixes=`git show --pretty=medium -s $sha | tr -d "\n" | sed -e 's/fixes:[[:space:]]*/\nfixes:/Ig' | grep "fixes:" | sed -e 's/\(fixes:[a-zA-Z0-9]*\).*$/\1/'`
>  
>  	# For each one try to extract the tag
>  	fixes_count=`echo "$fixes" | wc -l`
-- 
Br,

Andres


More information about the mesa-dev mailing list