[Mesa-dev] [PATCH] egl/android: remove flink name support

Tomasz Figa tfiga at chromium.org
Fri Apr 27 03:56:05 UTC 2018


Hi Rob,
On Fri, Apr 27, 2018 at 12:43 PM Chih-Wei Huang <cwhuang at linux.org.tw>
wrote:

> 2018-04-27 2:19 GMT+08:00 Robert Foss <robert.foss at collabora.com>:
> >
> > I've spent some time today preparing a #ifdef version of what robher
> > submitted.
> >
> > It's fine, but there is no way automatically enable the HAVE_DRM_GRALLOC
> > #define through the build tools. So a small simple patch adding the
shared
> > library dependency, and adding the -DHAVE_DRM_GRALLOC cflag is needed.

> I can add BOARD_USES_DRM_GRALLOC=true
> (like BOARD_USES_DRM_HWCOMPOSER=true)
> in our BoardConfig.mk.
> Then you can add these in Android.mk of mesa:

> ifeq ($(BOARD_USES_DRM_GRALLOC),true)
> LOCAL_CFLAGS += -DHAVE_DRM_GRALLOC
> endif

+1 to as Chih-Wei says for Android.mk.

For autotools or meson builds we don't need to define it at all, so no need
for any changes.

Best regards,
Tomasz


More information about the mesa-dev mailing list