[Mesa-dev] [PATCH 02/10] dri_interface: add __DRI_IMAGE_TRANSFER_USER_STRIDE

[Gurchetan Singh]

On Thu, Apr 26, 2018 at 3:08 PM, Marek Olšák <maraeo at gmail.com> wrote:
> On Thu, Apr 26, 2018 at 2:40 PM, Gurchetan Singh
> <gurchetansingh at chromium.org> wrote:
>>
>> On Thu, Apr 26, 2018 at 10:23 AM, Marek Olšák <maraeo at gmail.com> wrote:
>> > Gurchetan, can you confirm that the stride returned at alloc() is only
>> > used
>> > for CPU access and not for display programming?
>>
>> It really depends on how you couple your HWComposer and gralloc HALs
>> together.  For example, drm_hwcomposer calls drmModeAddFB2 from with
>> the allocation time stride:
>>
>> https://anongit.freedesktop.org/git/drm_hwcomposer.git
>>
>> For the minigbm + wayland_hwcomposer use case, we have a
>> GRALLOC_DRM_GET_STRIDE call that returns the allocation time pixel
>> stride to the Wayland client.
>>
>> We could:
>>       - Return the stride that works for display with
>> GRALLOC_DRM_GET_STRIDE
>>       - Return the stride that works for CPU access with the alloc() call.
>>
>> Just curious -- which Android app and/or test case is running into this
>> issue?
>
>
> There is some cros_gralloc test case that is failing, but nobody told me
> which one.

I can't find any bugs filed on the subject either (I've searched our
issue trackers).

> Can you have a look at the attached minigbm patch?

It looks fine.  If it fixes whatever bugs you're seeing, we'll
definitely land this.

> Marek
>