[Mesa-dev] [PATCH] egl/android: remove flink name support

[Emil Velikov]

On 26 April 2018 at 03:30, Chih-Wei Huang <cwhuang at linux.org.tw> wrote:
> 2018-04-25 19:55 GMT+08:00 Robert Foss <robert.foss at collabora.com>:
>> Hey Emil & Chih-Wei,
>>
>> On 04/24/2018 01:59 PM, Emil Velikov wrote:
>>>
>>> On 24 April 2018 at 12:28, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>>
>>>> On the topic of keeping the old code behind a #define or just removing
>>>> it, it'll be great if interested parties can reach a consensus.
>>>>
>>> Actually one can simply drop this code and drm_gralloc users can add a
>>> drm_ioctl_permit() hack.
>>> Namely: loosen the restrictions to consider render nodes identical to
>>> primary/card ones.
>>>
>>> Yes, it's a nasty hack, yet no worse than the existing one that
>>> removes the auth :-\
>>
>> I'm fine with adding a #define.
>> Chih-Wei: Do you have any objections?
>
> "keeping the old code behind a #define"?
> Sounds good to me. Thank you!

Having a look at the Android-x86 kernel:
The current hack in the permission check (see drm_ioctl_permit in [1])
effectively threats render nodes and primary nodes as the same thing.

Thus, on top of the current patch the !dri2_dpy->is_render_node check
should be removed, for Android-x86.
There's no need to keep the flink code around ;-)

-Emil

[1] https://osdn.net/projects/android-x86/scm/git/kernel/blobs/kernel-4.14/drivers/gpu/drm/drm_ioctl.c