[Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables
Dylan Baker
dylan at pnwbakers.com
Wed Apr 25 16:30:03 UTC 2018
Quoting Mike Lothian (2018-04-24 18:49:10)
> Can you also add radeon to the amd one? That works on autotools
>
> On Wed, 25 Apr 2018 at 02:16 Jordan Justen <jordan.l.justen at intel.com> wrote:
>
> Fixes: 5608d0a2cee "meson: use array type options"
> Cc: Dylan Baker <dylan at pnwbakers.com>
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
> meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 52a1075823f..c0e5c94d794 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -213,8 +213,8 @@ if _vulkan_drivers.contains('auto')
> endif
> endif
> if _vulkan_drivers != ['']
> - with_intel_vk = _drivers.contains('intel')
> - with_amd_vk = _drivers.contains('amd')
> + with_intel_vk = _vulkan_drivers.contains('intel')
> + with_amd_vk = _vulkan_drivers.contains('amd')
> with_any_vk = true
> endif
>
> --
> 2.16.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
At this point I think the ship has kinda sailed on changing the names of various
flags unless we're significantly reworking the functionality, we have a lot of
devs and some distros using meson already. Adding a compatibility option to
match autotools seems short sighted, the plan to remove autotools and scons
remains (once we have functional equivalence). I also like the symmetry of intel
and amd being the choices, but that's just personal taste.
Just my 2¢.
Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180425/2d5c7a26/attachment.sig>
More information about the mesa-dev
mailing list