[Mesa-dev] [PATCH v2 3/5] i965/clear: Remove an early return in fast_clear_depth

Nanley Chery nanleychery at gmail.com
Wed Apr 25 00:48:44 UTC 2018


Reduce complexity and allow the next patch to delete some code. With
this change, clear operations will still be skipped and setting the
aux_state will cause no side-effects.

Remove the associated comment which implies an early return.
---
 src/mesa/drivers/dri/i965/brw_clear.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_clear.c b/src/mesa/drivers/dri/i965/brw_clear.c
index fdc31cd9b68..6521141d7f6 100644
--- a/src/mesa/drivers/dri/i965/brw_clear.c
+++ b/src/mesa/drivers/dri/i965/brw_clear.c
@@ -230,10 +230,6 @@ brw_fast_clear_depth(struct gl_context *ctx)
    }
 
    if (!need_clear) {
-      /* If all of the layers we intend to clear are already in the clear
-       * state then simply updating the miptree fast clear value is sufficient
-       * to change their clear value.
-       */
       if (!same_clear_value) {
          /* BLORP updates the indirect clear color buffer when performing a
           * fast clear. Since we are skipping the fast clear here, we need to
@@ -241,7 +237,6 @@ brw_fast_clear_depth(struct gl_context *ctx)
           */
          intel_miptree_update_indirect_color(brw, mt);
       }
-      return true;
    }
 
    for (unsigned a = 0; a < num_layers; a++) {
-- 
2.16.2



More information about the mesa-dev mailing list