[Mesa-dev] [PATCH] nir: Look into uniform structs for samplers when counting num_textures.

Eric Anholt eric at anholt.net
Tue Apr 24 17:37:07 UTC 2018


Eric Anholt <eric at anholt.net> writes:

> mesa/st decides whether to update samplers after a program change based on
> whether num_textures is nonzero.  By not counting samplers in a uniform
> struct, we would segfault in
> KHR-GLES3.shaders.struct.uniform.sampler_vertex if it was run in the same
> context after a non-vertex-shader-uniform testcase (as is the case during
> a full conformance run).
>
> v2: Implement using two separate pure functions instead of updating
>     pointers.

Jason, did you like this version?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180424/958de021/attachment.sig>


More information about the mesa-dev mailing list