[Mesa-dev] [PATCH v2 06/12] glcpp/tests: Convert shell scripts to a python script

Dylan Baker dylan at pnwbakers.com
Tue Apr 24 16:02:31 UTC 2018


Quoting Juan A. Suarez Romero (2018-04-24 01:59:26)
> On Fri, 2018-04-20 at 10:23 -0700, Dylan Baker wrote:
> > Quoting Juan A. Suarez Romero (2018-04-20 10:18:03)
> > > On Thu, 2018-04-05 at 14:51 -0700, Dylan Baker wrote:
> > > > This ports glcpp-test.sh and glcpp-test-cr-lf.sh to a python script that
> > > > accepts arguments for each line ending type. This should allow for
> > > > better reporting to users.
> > > > 
> > > > Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
> > > 
> > > Hi!
> > > 
> > > 
> > > I think this patch is causing failing tests in "macOs Make"
> > > 
> > > https://travis-ci.org/Igalia/release-mesa/builds/369006234
> > > 
> > > 
> > >         J.A.
> > > 
> > 
> > Indeed it is. Vinson noticed it the other day and I just sent a patch to fix it
> > a few minutes ago :)
> > 
> 
> BTW, I think this failing is happening also on 18.1 branch, so probably you
> would like to nominate the fix for 18.1 stable release.
> 
> 
>         J.A.
> 
> > Dylan

I pushed the fix yesterday, and it has a Fixes tag. Assuming that I did it
correctly this time and didn't use the parent tree instead of the parent
commit...

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180424/2bd9517f/attachment.sig>


More information about the mesa-dev mailing list