[Mesa-dev] [Mesa-stable] [PATCH] anv/allocator: Don't srink either end of the block pool

[Jason Ekstrand]

On Mon, Apr 23, 2018 at 10:00 AM, Dylan Baker <dylan at pnwbakers.com> wrote:

> You have a typo in the commit message "srink" -> "shrink"
>

Thanks! Fixed.


> Quoting Jason Ekstrand (2018-04-20 22:15:00)
> > Previously, we only tried to ensure that we didn't shrink either end
> > below what was already handed out.  However, due to the way we handle
> > relocations with block pools, we can't shrink the back end at all.  It's
> > probably best to not shrink in either direction.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105374
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106147
> > Cc: mesa-stable at lists.freedesktop.org
> > ---
> >  src/intel/vulkan/anv_allocator.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_
> allocator.c
> > index f884ac3..642e161 100644
> > --- a/src/intel/vulkan/anv_allocator.c
> > +++ b/src/intel/vulkan/anv_allocator.c
> > @@ -508,12 +508,12 @@ anv_block_pool_grow(struct anv_block_pool *pool,
> struct anv_block_state *state)
> >        assert(center_bo_offset >= back_used);
> >
> >        /* Make sure we don't shrink the back end of the pool */
> > -      if (center_bo_offset < pool->back_state.end)
> > -         center_bo_offset = pool->back_state.end;
> > +      if (center_bo_offset < back_required)
> > +         center_bo_offset = back_required;
> >
> >        /* Make sure that we don't shrink the front end of the pool */
> > -      if (size - center_bo_offset < pool->state.end)
> > -         center_bo_offset = size - pool->state.end;
> > +      if (size - center_bo_offset < front_required)
> > +         center_bo_offset = size - front_required;
> >     }
> >
> >     assert(center_bo_offset % PAGE_SIZE == 0);
> > --
> > 2.5.0.400.gff86faf
> >
> > _______________________________________________
> > mesa-stable mailing list
> > mesa-stable at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-stable
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180423/c21fa271/attachment.html>