[Mesa-dev] [PATCH 3/4] intel/compiler: Silence unused parameter warnings in empty vec4_instruction_scheduler methods

[Jason Ekstrand]

First three are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Fri, Apr 20, 2018 at 7:59 AM, Ian Romanick <idr at freedesktop.org> wrote:

> From: Ian Romanick <ian.d.romanick at intel.com>
>
> src/intel/compiler/brw_schedule_instructions.cpp: In member function
> ‘virtual void vec4_instruction_scheduler::count_reads_remaining(backend_
> instruction*)’:
> src/intel/compiler/brw_schedule_instructions.cpp:764:72: warning: unused
> parameter ‘be’ [-Wunused-parameter]
>  vec4_instruction_scheduler::count_reads_remaining(backend_instruction
> *be)
>                                                                         ^~
> src/intel/compiler/brw_schedule_instructions.cpp: In member function
> ‘virtual void vec4_instruction_scheduler::setup_liveness(cfg_t*)’:
> src/intel/compiler/brw_schedule_instructions.cpp:769:51: warning: unused
> parameter ‘cfg’ [-Wunused-parameter]
>  vec4_instruction_scheduler::setup_liveness(cfg_t *cfg)
>                                                    ^~~
> src/intel/compiler/brw_schedule_instructions.cpp: In member function
> ‘virtual void vec4_instruction_scheduler::update_register_pressure(
> backend_instruction*)’:
> src/intel/compiler/brw_schedule_instructions.cpp:774:75: warning: unused
> parameter ‘be’ [-Wunused-parameter]
>  vec4_instruction_scheduler::update_register_pressure(backend_instruction
> *be)
>
>  ^~
> src/intel/compiler/brw_schedule_instructions.cpp: In member function
> ‘virtual int vec4_instruction_scheduler::get_register_pressure_benefit(
> backend_instruction*)’:
> src/intel/compiler/brw_schedule_instructions.cpp:779:80: warning: unused
> parameter ‘be’ [-Wunused-parameter]
>  vec4_instruction_scheduler::get_register_pressure_benefit(backend_instruction
> *be)
>
>       ^~
> src/intel/compiler/brw_schedule_instructions.cpp: In member function
> ‘virtual int vec4_instruction_scheduler::issue_time(backend_
> instruction*)’:
> src/intel/compiler/brw_schedule_instructions.cpp:1550:61: warning: unused
> parameter ‘inst’ [-Wunused-parameter]
>  vec4_instruction_scheduler::issue_time(backend_instruction *inst)
>                                                              ^~~~
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/intel/compiler/brw_schedule_instructions.cpp | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/intel/compiler/brw_schedule_instructions.cpp
> b/src/intel/compiler/brw_schedule_instructions.cpp
> index 0e793de4ddf..fa85045de74 100644
> --- a/src/intel/compiler/brw_schedule_instructions.cpp
> +++ b/src/intel/compiler/brw_schedule_instructions.cpp
> @@ -763,22 +763,22 @@ vec4_instruction_scheduler::
> vec4_instruction_scheduler(vec4_visitor *v,
>  }
>
>  void
> -vec4_instruction_scheduler::count_reads_remaining(backend_instruction
> *be)
> +vec4_instruction_scheduler::count_reads_remaining(backend_instruction *)
>  {
>  }
>
>  void
> -vec4_instruction_scheduler::setup_liveness(cfg_t *cfg)
> +vec4_instruction_scheduler::setup_liveness(cfg_t *)
>  {
>  }
>
>  void
> -vec4_instruction_scheduler::update_register_pressure(backend_instruction
> *be)
> +vec4_instruction_scheduler::update_register_pressure(backend_instruction
> *)
>  {
>  }
>
>  int
> -vec4_instruction_scheduler::get_register_pressure_benefit(backend_instruction
> *be)
> +vec4_instruction_scheduler::get_register_pressure_benefit(backend_instruction
> *)
>  {
>     return 0;
>  }
> @@ -1551,7 +1551,7 @@ fs_instruction_scheduler::issue_time(backend_instruction
> *inst)
>  }
>
>  int
> -vec4_instruction_scheduler::issue_time(backend_instruction *inst)
> +vec4_instruction_scheduler::issue_time(backend_instruction *)
>  {
>     /* We always execute as two vec4s in parallel. */
>     return 2;
> --
> 2.14.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180420/fd8783e0/attachment.html>