[Mesa-dev] [PATCH] glsl_to_nir: fix ir_binop_vector_extract handling

[Andriy Khulap]

Marek, thanks for suggestion.
But I've tested your patch <https://patchwork.freedesktop.org/patch/217304/>
and, unfortunately, it doesn't fix the
https://bugs.freedesktop.org/show_bug.cgi?id=105438

Regards, Andriy.

On Tue, Apr 17, 2018 at 8:33 PM, Marek Olšák <maraeo at gmail.com> wrote:

> Actually, if you just apply my patch, it should fix glsl_to_nir too.
>
> Marek
>
>
> On Tue, Apr 17, 2018 at 1:31 PM, Marek Olšák <maraeo at gmail.com> wrote:
>
>> Skipping an instruction is incorrect.
>>
>> I recommend something like this: https://patchwork.freedesktop.
>> org/patch/217304/
>>
>> Marek
>>
>>
>>
>> On Tue, Apr 3, 2018 at 8:32 AM, Andriy Khulap <andriy.khulap at gmail.com>
>> wrote:
>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105438
>>> Signed-off-by: Andriy Khulap <andriy.khulap at globallogic.com>
>>> Signed-off-by: Vadym Shovkoplias <vadym.shovkoplias at globallogic.com>
>>> ---
>>>  src/compiler/glsl/glsl_to_nir.cpp | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/src/compiler/glsl/glsl_to_nir.cpp
>>> b/src/compiler/glsl/glsl_to_nir.cpp
>>> index dbb58d82e8..1a0cd822a0 100644
>>> --- a/src/compiler/glsl/glsl_to_nir.cpp
>>> +++ b/src/compiler/glsl/glsl_to_nir.cpp
>>> @@ -1952,6 +1952,9 @@ nir_visitor::visit(ir_expression *ir)
>>>     case ir_quadop_vector:
>>>        result = nir_vec(&b, srcs, ir->type->vector_elements);
>>>        break;
>>> +   case ir_binop_vector_extract:
>>> +      /* Prevent the unreachable trap */
>>> +      break;
>>>
>>>     default:
>>>        unreachable("not reached");
>>> --
>>> 2.16.2
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180418/27841831/attachment.html>