[Mesa-dev] [PATCH 2/3] meson: Add library versions to swr drivers

[Dylan Baker]

Quoting Jan Alexander Steffens (heftig) (2018-04-14 10:23:21)
> This is for parity with autotools.
> 
> Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens at gmail.com>
> ---
>  src/gallium/drivers/swr/meson.build | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build
> index 4bcd4f4e38..e722602403 100644
> --- a/src/gallium/drivers/swr/meson.build
> +++ b/src/gallium/drivers/swr/meson.build
> @@ -201,6 +201,7 @@ if with_swr_arches.contains('avx')
>      link_args : [ld_args_gc_sections],
>      include_directories : [swr_incs],
>      dependencies : [dep_thread, dep_llvm],
> +    version : '0.0.0',
>      install : true,
>    )
>  endif
> @@ -233,6 +234,7 @@ if with_swr_arches.contains('avx2')
>      link_args : [ld_args_gc_sections],
>      include_directories : [swr_incs],
>      dependencies : [dep_thread, dep_llvm],
> +    version : '0.0.0',
>      install : true,
>    )
>  endif
> @@ -260,30 +262,32 @@ if with_swr_arches.contains('knl')
>      link_args : [ld_args_gc_sections],
>      include_directories : [swr_incs],
>      dependencies : [dep_thread, dep_llvm],
> +    version : '0.0.0',
>      install : true,
>    )
>  endif
>  
>  if with_swr_arches.contains('skx')
>    swr_skx_args = cpp.first_supported_argument(
>      '-target-cpu=x86-skylake', '-march=skylake-avx512', '-xCORE-AVX512',
>      prefix : '''
>        #if !defined(__AVX512F__) || !defined(__AVX512BW__)
>        # error
>        #endif ''',
>    )
>    if swr_skx_args == []
>      error('Cannot find SKX support for swr.')
>    endif
>  
>    swr_arch_defines += '-DHAVE_SWR_SKX'
>    swr_arch_libs += shared_library(
>      'swrSKX',
>      [files_swr_common, files_swr_arch],
>      cpp_args : [swr_cpp_args, swr_skx_args, '-DKNOB_ARCH=KNOB_ARCH_AVX512'],
>      link_args : [ld_args_gc_sections],
>      include_directories : [swr_incs],
>      dependencies : [dep_thread, dep_llvm],
> +    version : '0.0.0',
>      install : true,
>    )
>  endif
> -- 

I don't really see why it matters whether shared libraries that are for internal
use only have versions, but I don't object either:

Acked-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180416/9bcfb177/attachment.sig>