[Mesa-dev] [PATCH 19/45] swr/rast: Simplify #define usage in gen source file

George Kyriazis george.kyriazis at intel.com
Fri Apr 13 19:01:59 UTC 2018


Removed preprocessor defines from structures passed to LLVM jitted code.

The python scripts do not understand the preprocessor defines and ignores
them. So for fields that are compiled out due to a preprocessor define
the LLVM script accounts for them anyway because it doesn't know what
the defines are set to. The sanitize defines for open source are fine
in that they're safely used.
---
 src/gallium/drivers/swr/rasterizer/core/state.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/gallium/drivers/swr/rasterizer/core/state.h b/src/gallium/drivers/swr/rasterizer/core/state.h
index 47ffacf..084ca54 100644
--- a/src/gallium/drivers/swr/rasterizer/core/state.h
+++ b/src/gallium/drivers/swr/rasterizer/core/state.h
@@ -234,13 +234,12 @@ struct SWR_VS_CONTEXT
     uint32_t InstanceID;        // IN: Instance ID, constant across all verts of the SIMD
     simdscalari VertexID;       // IN: Vertex ID
     simdscalari mask;           // IN: Active mask for shader
-#if USE_SIMD16_FRONTEND
+
+    // SIMD16 Frontend fields.
     uint32_t AlternateOffset;   // IN: amount to offset for interleaving even/odd simd8 in simd16vertex output
-#if USE_SIMD16_VS
     simd16scalari mask16;       // IN: Active mask for shader (16-wide)
     simd16scalari VertexID16;   // IN: Vertex ID (16-wide)
-#endif
-#endif
+
     SWR_SHADER_STATS stats;     // OUT: shader statistics used for archrast.
 };
 
-- 
2.7.4



More information about the mesa-dev mailing list