[Mesa-dev] [PATCH 08/10] radv: handle CMASK/FMASK transitions only if DCC is disabled

Samuel Pitoiset samuel.pitoiset at gmail.com
Fri Apr 13 17:14:50 UTC 2018


DCC implies a fast-clear eliminate, so I think this sounds
reasonable.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/radv_cmd_buffer.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index afe953d90c..72fb6d6357 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -3841,9 +3841,7 @@ static void radv_handle_color_image_transition(struct radv_cmd_buffer *cmd_buffe
 			   !radv_layout_can_fast_clear(image, dst_layout, dst_queue_mask)) {
 			radv_fast_clear_flush_image_inplace(cmd_buffer, image, range);
 		}
-	}
-
-	if (radv_image_has_cmask(image) || radv_image_has_fmask(image)) {
+	} else if (radv_image_has_cmask(image) || radv_image_has_fmask(image)) {
 		if (radv_layout_can_fast_clear(image, src_layout, src_queue_mask) &&
 		    !radv_layout_can_fast_clear(image, dst_layout, dst_queue_mask)) {
 			radv_fast_clear_flush_image_inplace(cmd_buffer, image, range);
-- 
2.17.0



More information about the mesa-dev mailing list