[Mesa-dev] [PATCH] anv: fix number of planes for depth & stencil

[Nanley Chery]

On Thu, Apr 12, 2018 at 11:37:57AM -0700, Lionel Landwerlin wrote:
> We're not counting correctly with depth & stencil images.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105994
> ---
>  src/intel/vulkan/anv_private.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
> index 53115ae470f..a4297511bbb 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulkan/anv_private.h
> @@ -2356,6 +2356,10 @@ anv_image_aspect_get_planes(VkImageAspectFlags aspect_mask)
>     if (aspect_mask & VK_IMAGE_ASPECT_PLANE_2_BIT)
>        planes++;
>  
> +   if (aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT &&
> +       aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)
> +      planes++;
> +

I think we usually use curly braces for multi-line if-statements. I
can't find that written down anywhere though.

With or without that change, this patch is
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>

>     return planes;
>  }
>  
> -- 
> 2.17.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev