[Mesa-dev] [PATCH 2/2] mesa: include mtypes.h less

Brian Paul brianp at vmware.com
Thu Apr 12 13:34:20 UTC 2018


On 04/11/2018 02:09 PM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> - remove mtypes.h from most header files
> - add main/menums.h for often used definitions

FWIW, mtypes.h was originally types.h.  A long time ago, there was some 
obscure platform that had a /usr/include/types.h header and the compiler 
would errantly include it instead of Mesa's types.h.  So I renamed 
types.h to mtypes.h to work around that.

If you wanted to name the new file enums.h instead of menums.h that'd be 
OK.  No big deal though.

Otherwise, the series looks OK to me, though I see that Dylan found an 
issue.

Reviewed-by: Brian Paul <brianp at vmware.com>




More information about the mesa-dev mailing list