[Mesa-dev] [Mesa-stable] [PATCH] egl/wayland: Make swrast display_sync the correct queue

Juan A. Suarez Romero jasuarez at igalia.com
Wed Apr 11 08:39:51 UTC 2018


On Thu, 2018-03-22 at 16:45 +0000, Eric Engestrom wrote:
> On Thursday, 2018-03-22 15:28:49 +0000, Daniel Stone wrote:
> > On 22 March 2018 at 15:20, Derek Foreman <derekf at osg.samsung.com> wrote:
> > > commit 03dd9a88b0be17ff0ce91e92f6902a9a85ba584a introduced per surface
> > > queues, but the display_sync for swrast_commit_backbuffer remained on
> > > the old queue.  This is likely to break when dispatching the correct
> > > queue at the top of function (which can't dispatch the sync callback
> > > we're waiting for).
> > > 
> > > The easiest known reproduction case is running weston-subsurfaces under
> > > weston --use-pixman
> > 
> > Oh dear. Pushed now with review. For future though, can you please use
> > the 'Fixes:' annotation, which in this case would've been for
> > 03dd9a88b0be? Don't feel too bad though, because I also forgot to add
> > it when pushing.
> 
> We want this in stable, right?
> Would've been done automatically with the Fixes: tag, but I cc'ed
> mesa-stable@ now, so it's nominated :)
> 

I've cherry-picked this for next 18.0 stable release too.


	J.A.

> > 
> > Cheers,
> > Daniel
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable


More information about the mesa-dev mailing list