[Mesa-dev] [PATCH 3/3] egl/x11: Handle both depth 30 formats for eglCreateImage().

[Ilia Mirkin]

On Tue, Apr 10, 2018 at 4:42 AM, Michel Dänzer <michel at daenzer.net> wrote:
> On 2018-04-10 10:22 AM, Mario Kleiner wrote:
>> On 04/09/2018 12:12 PM, Michel Dänzer wrote:
>>> On 2018-04-06 08:56 PM, Mario Kleiner wrote:
>>>
>>> I'm interested in the full xdpyinfo *at screen depth 30*, in particular
>>> whether it lists only one variant of depth 30 visuals. If so, one
>>> possibility for a kludge would be to just look at any depth 30 visual.
>>
>> Ok, the fresh v2 patch implements that kludge. This one retested to work
>> on nouveau, ati, intel.
>>
>> On intel and nouveau we only get one channel mask for depth 30 visuals
>> in xdpyinfo. On amd we get both masks for xrgb2101010 and xbgr2101010,
>> as the amd gallium drivers expose both formats, but the ordering is
>> xrgb2101010 first, so that's fine when picking the first depth 30 visual
>> to get the channel mask for decisions.
>
> Hmm, that sounds fragile though when there are both variants; is there
> any guarantee they can't appear in the opposite order?

It seems like nouveau is stirring a bit of a hornet's nest here.
Unfortunately there's not a whole lot I can do about hw scanout format
support (rgb10x2 only, no bgr10x2 support until Kepler), but is there
something else that the DDX and/or mesa driver should be doing to
avoid some of this pain?

Should we get the *other* ddx's to avoid exposing both masks?

  -ilia