[Mesa-dev] [PATCH v3 2/7] nir/spirv: Fix warning and add missing breaks.

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Tue, Apr 10, 2018 at 7:37 AM, Daniel Schürmann <
daniel.schuermann at campus.tu-berlin.de> wrote:

> ---
>  src/compiler/spirv/spirv_to_nir.c | 2 ++
>  src/compiler/spirv/vtn_subgroup.c | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/src/compiler/spirv/spirv_to_nir.c
> b/src/compiler/spirv/spirv_to_nir.c
> index 78c1e9ff59..28274311c2 100644
> --- a/src/compiler/spirv/spirv_to_nir.c
> +++ b/src/compiler/spirv/spirv_to_nir.c
> @@ -3361,10 +3361,12 @@ vtn_handle_preamble_instruction(struct
> vtn_builder *b, SpvOp opcode,
>
>        case SpvCapabilityGroupNonUniformQuad:
>           spv_check_supported(subgroup_quad, cap);
> +         break;
>
>        case SpvCapabilityGroupNonUniformArithmetic:
>        case SpvCapabilityGroupNonUniformClustered:
>           spv_check_supported(subgroup_arithmetic, cap);
> +         break;
>
>        case SpvCapabilityVariablePointersStorageBuffer:
>        case SpvCapabilityVariablePointers:
> diff --git a/src/compiler/spirv/vtn_subgroup.c b/src/compiler/spirv/vtn_
> subgroup.c
> index bd3143962b..ecec3aa62d 100644
> --- a/src/compiler/spirv/vtn_subgroup.c
> +++ b/src/compiler/spirv/vtn_subgroup.c
> @@ -277,6 +277,8 @@ vtn_handle_subgroup(struct vtn_builder *b, SpvOp
> opcode,
>        case 2:
>           op = nir_intrinsic_quad_swap_diagonal;
>           break;
> +      default:
> +         vtn_fail("Invalid constant value in OpGroupNonUniformQuadSwap");
>        }
>        vtn_build_subgroup_instr(b, op, val->ssa, vtn_ssa_value(b, w[4]),
>                                 NULL, 0, 0);
> --
> 2.14.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180410/5a6ecd18/attachment.html>