[Mesa-dev] [PATCH 2/2] bin/install_megadrivers: rename a few variables to make things clearer

Dylan Baker dylan at pnwbakers.com
Mon Apr 9 21:02:52 UTC 2018


Originally the "each" variable was just a part of the "drivers"
variable. It's not anymore so it's a bit ambiguous.

Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
---
 bin/install_megadrivers.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py
index c04a2a3eb34..8d9ed9c6dce 100755
--- a/bin/install_megadrivers.py
+++ b/bin/install_megadrivers.py
@@ -46,23 +46,23 @@ def main():
         os.makedirs(to)
     shutil.copy(args.megadriver, master)
 
-    for each in args.drivers:
-        driver = os.path.join(to, each)
+    for driver in args.drivers:
+        abs_driver = os.path.join(to, driver)
 
-        if os.path.exists(driver):
-            os.unlink(driver)
-        print('installing {} to {}'.format(args.megadriver, driver))
-        os.link(master, driver)
+        if os.path.exists(abs_driver):
+            os.unlink(abs_driver)
+        print('installing {} to {}'.format(args.megadriver, abs_driver))
+        os.link(master, abs_driver)
 
         try:
             ret = os.getcwd()
             os.chdir(to)
 
-            name, ext = os.path.splitext(each)
+            name, ext = os.path.splitext(driver)
             while ext != '.so':
                 if os.path.exists(name):
                     os.unlink(name)
-                os.symlink(each, name)
+                os.symlink(driver, name)
                 name, ext = os.path.splitext(name)
         finally:
             os.chdir(ret)
-- 
2.17.0



More information about the mesa-dev mailing list