[Mesa-dev] [PATCH 1/2] radv: Don't set instance count using predication.

[Samuel Pitoiset]

For the series:

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 04/09/2018 04:56 PM, Bas Nieuwenhuizen wrote:
> The packet can sometimes be skipped, but we still think the change takes effect.
> 
> This just makes the packet always take effect.
> 
> Fixes: ad11fc3571 "radv: don't emit unneeded vertex state."
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105942
> ---
>   src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index d9f12a351e..d8795ba562 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -2958,7 +2958,7 @@ radv_emit_draw_packets(struct radv_cmd_buffer *cmd_buffer,
>   		}
>   
>   		if (state->last_num_instances != info->instance_count) {
> -			radeon_emit(cs, PKT3(PKT3_NUM_INSTANCES, 0, state->predicating));
> +			radeon_emit(cs, PKT3(PKT3_NUM_INSTANCES, 0, false));
>   			radeon_emit(cs, info->instance_count);
>   			state->last_num_instances = info->instance_count;
>   		}
>