[Mesa-dev] [PATCH 3/4] radv: rename radv_cmd_buffer_update_vertex_descriptors()

[Bas Nieuwenhuizen]

On Thu, Apr 5, 2018 at 11:42 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> ... to radv_flush_vertex_buffers().
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 3ae3e33c3b..05610adee8 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -1476,7 +1476,8 @@ radv_flush_constants(struct radv_cmd_buffer *cmd_buffer,
>  }
>
>  static void
> -radv_cmd_buffer_update_vertex_descriptors(struct radv_cmd_buffer *cmd_buffer, bool pipeline_is_dirty)
> +radv_flush_vertex_buffers(struct radv_cmd_buffer *cmd_buffer,

Can we keep descriptors in there instead of buffers? To keep it clear
it does nothing with the data?

> +                         bool pipeline_is_dirty)
>  {
>         if ((pipeline_is_dirty ||
>             (cmd_buffer->state.dirty & RADV_CMD_DIRTY_VERTEX_BUFFER)) &&
> @@ -1530,7 +1531,7 @@ radv_cmd_buffer_update_vertex_descriptors(struct radv_cmd_buffer *cmd_buffer, bo
>  static void
>  radv_upload_graphics_shader_descriptors(struct radv_cmd_buffer *cmd_buffer, bool pipeline_is_dirty)
>  {
> -       radv_cmd_buffer_update_vertex_descriptors(cmd_buffer, pipeline_is_dirty);
> +       radv_flush_vertex_buffers(cmd_buffer, pipeline_is_dirty);
>         radv_flush_descriptors(cmd_buffer, VK_SHADER_STAGE_ALL_GRAPHICS);
>         radv_flush_constants(cmd_buffer, cmd_buffer->state.pipeline,
>                              VK_SHADER_STAGE_ALL_GRAPHICS);
> --
> 2.16.3
>