[Mesa-dev] [PATCH] loader: disable virgl driver when no 3D for virtio

[Emil Velikov]

On 5 April 2018 at 14:45, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Shouldn't this just be handled as in, e.g.,
>
> https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/winsys/nouveau/drm/nouveau_drm_winsys.c#n97
>
> i.e. return an error in the driver-specific loader? This create
> function should fail:
>
> https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c#n897
>
Indeed. The radeon and amdgpu drivers also use a similar approach.
Be that to check if the kernel module is too old, or a required
feature is missing.

Keeping the ioctl in virgl_drm_winsys_create, alongside it's brethren
would help with consistency.

-Emil