[Mesa-dev] [PATCH] radv: disable TC-compat HTILE on Tonga and Iceland

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu Apr 5 11:18:25 UTC 2018


On Thu, Apr 5, 2018 at 10:32 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Ported from RadeonSI.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_image.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index dd3189c67d..44caf0eeae 100644
> --- a/src/amd/vulkan/radv_image.c
> +++ b/src/amd/vulkan/radv_image.c
> @@ -72,6 +72,11 @@ radv_image_is_tc_compat_htile(struct radv_device *device,
>         if (device->physical_device->rad_info.chip_class < VI)
>                 return false;
>
> +       /* TC-compat HTILE seems buggy on Tonga/Iceland. */

Can we please get a reference on what seems buggy about it? This could
very well something that is done incorrectly,s o I'd like something to
check to see if that is fixed.

> +       if (device->physical_device->rad_info.family == CHIP_TONGA ||
> +           device->physical_device->rad_info.family == CHIP_ICELAND)
> +               return false;
> +
>         if (pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT)
>                 return false;
>
> --
> 2.16.3
>


More information about the mesa-dev mailing list