[Mesa-dev] [PATCH] gallium: add CAP for postprocess filters

[Marek Olšák]

On Wed, Apr 4, 2018 at 10:30 AM, Roland Scheidegger <sroland at vmware.com>
wrote:

> Am 04.04.2018 um 05:42 schrieb Timothy Arceri:
> > On 04/04/18 13:22, Roland Scheidegger wrote:
> >> Am 04.04.2018 um 05:03 schrieb Timothy Arceri:
> >>> On 04/04/18 12:44, Roland Scheidegger wrote:
> >>>> Am 04.04.2018 um 04:32 schrieb Timothy Arceri:
> >>>>> On 04/04/18 11:58, Roland Scheidegger wrote:
> >>>>>> AFAIK these filters (and I've never looked into them) should be
> >>>>>> transparent to hw drivers. Hence a cap bit doesn't make sense, and
> if
> >>>>>> it's broken we shouldn't just paper over this.
> >>>>>
> >>>>> I created a CAP because the AMD devs have no interest in supporting
> >>>>> this
> >>>>> feature [1]. Even if they are transparent to drivers I don't see why
> >>>>> drivers should be forced to enable them if they don't want to. CCing
> >>>>> Marek for his opinion.
> >>>>
> >>>> I still don't see why using cap bits for bugs is a good idea.
> >>>
> >>> Well I see it as a CAP for an unwanted feature that just happens to not
> >>> work currently.
> >>>
> >>>> (Even more so if the bug actually would be in the postprocess, but
> I've
> >>>> no idea there really.)
> >>>
> >>> It's crashing in src/gallium/drivers/radeonsi/si_state_draw.c
> >>
> >> Doesn't necessarily mean the bug is in the driver.
> >> Not sure it's really worth fixing it this way neither - people are
> >> probably just as confused why pp won't work than they are if it's
> >> crashing...
> >
> > Well I can either update the webpage to say its disabled for radeonsi or
> > I can close the bugs as won't fix and let people wonder why its crashing
> > potentially filling another bug report. The first bug was filed a year
> > ago and nobody seems to want to fix it. Either way I don't care to much
> > but disabling the feature seems like a better way to go than just
> > letting it crash forever.
>
> Alright, if the bug is that old I suppose there's really no interest in
> actually fixing it...
> So I suppose that would be an improvement...
>

I've just fixed it. The patches are on the ML.

Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180404/9f6b4062/attachment.html>