[Mesa-dev] [PATCH] st/mesa: Also use PIPE_FORMAT_R8G8B8A8_SRGB for framebuffer_sRGB.

Brian Paul brianp at vmware.com
Tue Apr 3 16:37:06 UTC 2018


On 04/03/2018 10:06 AM, Jakob Bornecrantz wrote:
> When running virgl on a GLES host the only sRGB formats that support
> rendering is RGBA and RGBX. That pipe format is in the sRGB default
> lists that the state tracker uses when mapping mesa formats.
> 
> Cheers, Jakob.
> 
> Signed-off-by: Jakob Bornecrantz <jakob at collabora.com>
> ---
>   src/mesa/state_tracker/st_extensions.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c
> index bea61f21cb..0dc8adb262 100644
> --- a/src/mesa/state_tracker/st_extensions.c
> +++ b/src/mesa/state_tracker/st_extensions.c
> @@ -711,7 +711,8 @@ void st_init_extensions(struct pipe_screen *screen,
>   
>         { { o(EXT_framebuffer_sRGB) },
>           { PIPE_FORMAT_A8B8G8R8_SRGB,
> -          PIPE_FORMAT_B8G8R8A8_SRGB },
> +          PIPE_FORMAT_B8G8R8A8_SRGB,
> +          PIPE_FORMAT_R8G8B8A8_SRGB },
>            GL_TRUE }, /* at least one format must be supported */
>   
>         { { o(EXT_packed_float) },
> 

LGTM.

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list