[Mesa-dev] [PATCH] radv: enable VK_EXT_shader_viewport_index_layer

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Apr 3 10:01:00 UTC 2018


Has someone grown tests for this since the time I sent patches for
enabling this to the list?

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Mon, Apr 2, 2018 at 6:17 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> The driver already supports exporting the Layer and ViewportIndex
> built-ins from vertex or tessellation shaders.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_extensions.py | 1 +
>  src/amd/vulkan/radv_shader.c      | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py
> index cbb02f138a..8cb0b7aa7d 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -92,6 +92,7 @@ EXTENSIONS = [
>      Extension('VK_EXT_external_memory_host',              1, 'device->rad_info.has_userptr'),
>      Extension('VK_EXT_global_priority',                   1, 'device->rad_info.has_ctx_priority'),
>      Extension('VK_EXT_sampler_filter_minmax',             1, 'device->rad_info.chip_class >= CIK'),
> +    Extension('VK_EXT_shader_viewport_index_layer',       1, True),
>      Extension('VK_AMD_draw_indirect_count',               1, True),
>      Extension('VK_AMD_gcn_shader',                        1, True),
>      Extension('VK_AMD_rasterization_order',               1, 'device->rad_info.chip_class >= VI && device->rad_info.max_se >= 2'),
> diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
> index f150a20e3b..f46beab8c1 100644
> --- a/src/amd/vulkan/radv_shader.c
> +++ b/src/amd/vulkan/radv_shader.c
> @@ -217,6 +217,7 @@ radv_shader_compile_to_nir(struct radv_device *device,
>                                 .variable_pointers = true,
>                                 .gcn_shader = true,
>                                 .trinary_minmax = true,
> +                               .shader_viewport_index_layer = true,
>                         },
>                 };
>                 entry_point = spirv_to_nir(spirv, module->size / 4,
> --
> 2.16.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list