[Mesa-dev] [PATCH 5/7] i965: use _mesa_geometry_width/height/layers/samples for programming geometry of framebuffer to GEN

[Rogovin, Kevin]

Hello,


> No, because the non-shared code is (by your own admission) untested and/or dead code.  Untested code is broken code.  I would personally be ok with a lot > of the changes that just replace fb->Width with
> _mesa_geometric_width(fb) since it's effectively just replacing a direct access with a getter.  However, almost half of the patch is updating the upload_sf_vp > function which is only used for gen <= 5.  A comment or assert there would be sufficient rather than reworking it.

Fair enough. Would the following be good:
 - keep all those that replace fb->whatever with _mesa_geomety_whatever,
 - instead of the ick I have done to upload_sf_vp, place a big comment warning

I would be happy with the above  as it addresses my main concern and the dead-is-broken code concern as well. If I had physical access to a Gen4 and 5 box I would test it and if it worked, enable the extension on those platforms as well.

-Kevin