[Mesa-dev] [PATCH 2/2] st/mesa: also try PIPE_FORMAT_R10G10B10A2_UNORM for GL_RGB10

[Brian Paul]

R-b?

-Brian

On 04/28/2015 05:47 PM, Ilia Mirkin wrote:
> That's... really asymmetrical. There's a
> PIPE_FORMAT_R10G10B10X2_SNORM. Oh well -- no reason to add it in just
> for this.
>
> On Tue, Apr 28, 2015 at 7:47 PM, Brian Paul <brianp at vmware.com> wrote:
>> Unless I'm not seeing it, there is no such gallium format.
>>
>> -Brian
>>
>>
>> On 04/28/2015 04:22 PM, Ilia Mirkin wrote:
>>>
>>> Presumably you should also include RGB10_X2 while you're at it?
>>>
>>> With that, Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>>
>>> On Tue, Apr 28, 2015 at 6:16 PM, Brian Paul <brianp at vmware.com> wrote:
>>>>
>>>> ---
>>>>    src/mesa/state_tracker/st_format.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/src/mesa/state_tracker/st_format.c
>>>> b/src/mesa/state_tracker/st_format.c
>>>> index 181465d..db7b5b7 100644
>>>> --- a/src/mesa/state_tracker/st_format.c
>>>> +++ b/src/mesa/state_tracker/st_format.c
>>>> @@ -991,7 +991,7 @@ static const struct format_mapping format_map[] = {
>>>>       {
>>>>          { GL_RGB10, 0 },
>>>>          { PIPE_FORMAT_B10G10R10X2_UNORM, PIPE_FORMAT_B10G10R10A2_UNORM,
>>>> -        DEFAULT_RGB_FORMATS }
>>>> +        PIPE_FORMAT_R10G10B10A2_UNORM, DEFAULT_RGB_FORMATS }
>>>>       },
>>>>       {
>>>>          { GL_RGB10_A2, 0 },
>>>> --
>>>> 1.9.1
>>>>
>>>> _______________________________________________
>>>> mesa-dev mailing list
>>>> mesa-dev at lists.freedesktop.org
>>>>
>>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=AwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=IuMA5FK_1tNFsFKLmtJFxFREEyZXHga_CgoCrfxxV8Y&s=EF5qZZulTwh5vLidYWf7vMagDvZQexfoUJ9PjS1uHZI&e=
>>
>>