[Mesa-dev] [PATCH 01/18] winsys/radeon: move radeon_winsys.h up one directory

[Emil Velikov]

On 28 April 2015 at 07:51, Chia-I Wu <olvaffe at gmail.com> wrote:
> On Tue, Apr 28, 2015 at 2:19 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 28 April 2015 at 03:30, Michel Dänzer <michel at daenzer.net> wrote:
>>> On 28.04.2015 03:57, Marek Olšák wrote:
>>>> Can you elaborate on what amdgpu/sw would be good for? Frankly I don't
>>>> see a point, therefore we don't need the "drm" subdirectory.
>>>
>>> I think Emil's main point (which I agree with) is that radeon_winsys.h
>>> should live somewhere under src/gallium/drivers/, probably
>>> src/gallium/drivers/radeon/, because the winsys interface is defined by
>>> the drivers, not the winsys. All other drivers have their *_winsys.h
>>> headers there.
>>>
>>> Maybe amdgpu/sw wasn't a good example, but at some point there might be
>>> e.g. amdgpu/haiku. ;)
>>>
>> Well said Michel - this is exactly what I meant.
> ilo moved its intel_winsys.h to src/gallium/drivers/ilo because Emil
> wouldn't let me put it in src/gallium/winsys/intel, which is exactly
> what this patch tries to do for radeon :)
>
Here we (will) have two different winsys implementations (radeon,
amdgpu), providing the same interface for the same radeon driver(s). I
hope that my suggestion for consistency did not come as pushy.

-Emil